-
Notifications
You must be signed in to change notification settings - Fork 955
add support for .rust-toolchain.toml
#3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cargo-crev will need to be updated too if this PR ends up getting accepted: https://github.com/crev-dev/cargo-crev/blob/5d9574d43634013ef73684f2af35f37db8ee8bfe/crev-lib/src/util/mod.rs#L118-L122 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: "The legacy format is not available in rust-toolchain.toml
files." (in between the other two doc changes) could be updated to mention both files explicitly.
So at this point both @kinnison and I dislike hiding the file. I'm not sure we can provide a sensible rational that can be argued through though. For now, since this would potentially affect all users and would not be a reversible decision, I think we should not merge a patch adding it. |
Well, we provided a rational argument in the original issue, so perhaps you can find something there in particular that you do not like? Otherwise, it is hard to reply.
I agree a fair amount of people would probably start using it (which is one reason it would be nice to have! :), but it is backwards compatible, so I am not sure I understand how it would affect all users -- it should not affect any existing one, no? |
This PR adds support for
.rust-toolchain.toml
files like described in #3182.I'm not sure if this is the normal procedure or is a RFC needed?